Add Actions script to do regular shell format check

Description

Checklist

hide

Activity

Show:

Igor Pecovnik June 11, 2024 at 7:46 PM

I hope can add some comments here as he did this implementation. IIRC we said that we need this to check everything what comes to PR, while internal functionality only takes care of what is under /lib which is core of framework.

I think we can be happy with detecting errors. Not sure if its worth expanding this further.

David BBK June 11, 2024 at 6:23 PM

Apparently, we have this shell format check script here: https://github.com/armbian/build/blob/main/lib/tools/shellfmt.sh#L66-L75

I guess this is being used locally as a pre-commit or “on demand”.

Btw, when and what do we want to be accomplished here?

  • [WHEN] On schedule, run a new Github workflow? (I guess so)

  • [WHAT] List files whose formatting differs from shfmt's AND exit the job according to the exit of the shell check?

    • Or do we want to also correct (modify + commit) those files, as part of the workflow?

Details

Assignee

Fix versions

Reporter

Components

Priority

Created September 6, 2023 at 5:45 PM
Updated December 9, 2024 at 8:11 PM