Failed to calculate available space

Description

Under certain conditions - mounts - build scripts return double value for free space which resoults in syntax error.

https://github.com/armbian/build/blob/master/lib/general.sh#L1255-L1256

Environment

None

Checklist

hide

Activity

Igor PecovnikJuly 31, 2021 at 8:23 PM

adding tail -1 would be good enough IHMO.

Lane JennisonJuly 31, 2021 at 5:53 PM

cause in this case was due to filesystem being mounted via systemd automounter

 

root@ubuntu:/home/debian# mount -a root@ubuntu:/home/debian# findmnt --target /opt/actions-runner/_work/build/build/build TARGET SOURCE FSTYPE OPTIONS /opt systemd-1 autofs rw,relatime,fd=62,pgrp=1,timeout=0,minproto=5,maxproto=5,direct,pipe_ino=16099 /opt /dev/vdb1 ext4 rw,noatime,nodiratime root@ubuntu:/home/debian# umount /opt umount: /opt: target is busy. root@ubuntu:/home/debian# findmnt --target /opt/actions-runner/_work/build/build/build TARGET SOURCE FSTYPE OPTIONS /opt systemd-1 autofs rw,relatime,fd=62,pgrp=1,timeout=0,minproto=5,maxproto=5,direct,pipe_ino=16099 /opt /dev/vdb1 ext4 rw,noatime,nodiratime

removed automounter flag and now its fine

 

 

oot@ubuntu:/home/debian# findmnt --target /opt/actions-runner/_work/build/build/build TARGET SOURCE FSTYPE OPTIONS /opt /dev/vdb1 ext4 rw,noatime,nodiratime root@ubuntu:/home/debian# fgrep opt /etc/fstab PARTLABEL=Armbian /opt ext4 defaults,nofail,noatime,nodiratime 0 2


It’s possible that a system using bindmounts might return multiple results as well, but not sure. I’d either embrace as edge case, or just |tail -n1 the calculation

Unresolved

Details

Assignee

Reporter

Components

Affects versions

Priority

Created July 31, 2021 at 3:53 PM
Updated June 22, 2023 at 4:10 PM